Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Mempool handling for moonlight txs #2237

Merged
merged 7 commits into from
Sep 4, 2024
Merged

node: Mempool handling for moonlight txs #2237

merged 7 commits into from
Sep 4, 2024

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Aug 31, 2024 •
edited
Loading

  • Reuse the current mempool features for moonlight txs too
    • Check nonce repetition
    • Transaction replacement (according to gas price)
  • Don't discard transactions that are not ready yet (nonce is not the next one)

@herr-seppia herr-seppia force-pushed the moonlight-mempool branch 2 times, most recently from 38d4022 to 0d0deb5 Compare September 3, 2024 09:13
@herr-seppia herr-seppia changed the title node: Mempool strategies for moonlight txs node: Mempool handling for moonlight txs Sep 3, 2024
@herr-seppia herr-seppia marked this pull request as ready for review September 3, 2024 09:14
@herr-seppia
transfer-contract: refactor spend_and_execute
f82851c 
- Change `spend_and_execute_moonlight` to `spend_moonlight`
- Change `spend_and_execute_phoenix` to `spend_phoenix`
- Change `spend_and_execute` to handle transitory and call execution
@herr-seppia
node-data: add SpendingId struct
03ecdec
@herr-seppia
node: replace nullifiers with spendingId
f6a9c77
@herr-seppia
execution-core: add PANIC_NONCE_NOT_READY
056090a
moCello
moCello requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all the nullifiers are included in the SpendingId for phoenix-transactions. For the rest it looks good!

node-data/src/ledger/transaction.rs Show resolved Hide resolved
moCello
moCello reviewed Sep 4, 2024
View reviewed changes
node/src/mempool.rs Outdated Show resolved Hide resolved
moCello
moCello approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herr-seppia herr-seppia merged commit 9479c10 into master Sep 4, 2024
15 checks passed
@herr-seppia herr-seppia deleted the moonlight-mempool branch September 4, 2024 11:09
@herr-seppia herr-seppia mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

@fed-franz fed-franz Awaiting requested review from fed-franz

@ureeves ureeves Awaiting requested review from ureeves

@goshawk-3 goshawk-3 Awaiting requested review from goshawk-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herr-seppia @moCello